[confmap] use github.com/go-viper/mapstructure/v2 #9634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
update_mapstructure
branch
from
efb6ccb
to
19785a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9634 +/- ##
==========================================
+ Coverage 90.72% 90.87% +0.14%
==========================================
Files 347 347
Lines 18224 18325 +101
==========================================
+ Hits 16534 16653 +119
+ Misses 1367 1346 -21
- Partials 323 326 +3 ☔ View full report in Codecov by Sentry. |
atoulme
force-pushed
the
update_mapstructure
branch
from
19785a0
to
c81e10e
Compare
bogdandrutu
approved these changes
Feb 26, 2024
yurishkuro
approved these changes
Feb 26, 2024
dmitryax
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
LGTM. Especially given that https://github.com/knadh/koanf that we use already migrated to the fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update mapstructure to use a maintained fork, github.com/go-viper/mapstructure/v2.
See mitchellh/mapstructure#349 for context
Link to tracking Issue:
#9161
Creating this as WIP to see if all tests pass.